gh-133183: Include IPHONEOS_DEPLOYMENT_TARGET in iOS shim targets. #133184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!buildbot iOS |
|
🤖 New build scheduled with the buildbot fleet by @freakboy3742 for commit 767e668 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133184%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
This was referenced May 1, 2025
ned-deily
approved these changes
May 1, 2025
|
Thanks @freakboy3742 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 1, 2025
…ts. (pythonGH-133184) Include IPHONEOS_DEPLOYMENT_TARGET in iOS shim targets. (cherry picked from commit 6e907c4) Co-authored-by: Russell Keith-Magee <[email protected]>
|
GH-133234 is a backport of this pull request to the 3.13 branch. |
freakboy3742
added a commit
that referenced
this pull request
May 1, 2025
…ets. (GH-133184) (#133234) Include IPHONEOS_DEPLOYMENT_TARGET in iOS shim targets. (cherry picked from commit 6e907c4) Co-authored-by: Russell Keith-Magee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures that
IPHONEOS_DEPLOYMENT_TARGETis included in the target triple used by the iOS compiler shims.This is needed to ensure that an environment-provided
IPHONEOS_DEPLOYMENT_TARGETisn't ignored (or superseded) by the "no min SDK version" implied by-target arm64-apple-ioset al.